[libvirt] [PATCH] Add actions to virDomainLifecycle enum
Jim Fehlig
jfehlig at novell.com
Fri Aug 20 21:36:12 UTC 2010
Eric Blake wrote:
> On 08/12/2010 11:15 AM, Jim Fehlig wrote:
>
>>>> +++ b/src/conf/domain_conf.c
>>>> @@ -81,7 +81,9 @@ VIR_ENUM_IMPL(virDomainLifecycle, VIR_DOMAIN_LIFECYCLE_LAST,
>>>> "destroy",
>>>> "restart",
>>>> "rename-restart",
>>>> - "preserve")
>>>> + "preserve",
>>>> + "coredump-destroy",
>>>> + "coredump-restart")
>>>>
>>>>
>>> Hmm. These two new values are only valid for on_crash, but I don't see
>>> any code that rejects them for on_reboot or on_poweroff. Do we need a
>>> separate enum here, or do we just need to add better checking to the
>>> remaining clients to detect enum values they can't support?
>>>
>>>
>> Good point. I moved these new options into a new enum and adjusted the
>> code accordingly.
>>
>> V2 attached.
>>
>
> ACK. I went ahead and added the <since> tag, then pushed (here's what I
> squashed in):
>
> diff --git i/docs/formatdomain.html.in w/docs/formatdomain.html.in
> index df5e53d..edee933 100644
> --- i/docs/formatdomain.html.in
> +++ w/docs/formatdomain.html.in
> @@ -367,7 +367,8 @@
> </dl>
>
> <p>
> - on_crash supports these additional actions.
> + on_crash supports these additional
> + actions <span class="since">since 0.8.4</span>.
> </p>
>
Thanks Eric!
Jim
More information about the libvir-list
mailing list