[libvirt] Xencaptest.c failing?

[Matthias Bolte]

2010/8/27 Thomas Graves <tgraves at yahoo-inc.com>:
> Hello,
>
> We are running xen3.4.3 on rhel5.4 and trying to build the new libvirt 0.8.3
> and the xencaptest is failing.
>
> It seems to be failing because it is passing NULL in as the virtconn and it
> ends up going into the following code section in function
> xenHypervisorBuildCapabilities:
>
>   if (sys_interface_version >= SYS_IFACE_MIN_VERS_NUMA) {
>        if (xenDaemonNodeGetTopology(conn, caps) != 0) {
>            virCapabilitiesFree(caps);
>            return NULL;
>        }
>    }
>
> And that throws an error because conn is empty.  I don't see how that could
> ever work with the virtconn NULL.  If I force it to be lower version number
> then it passes fine.  I think its figuring we are sys_interface_version=6.
>
> Any ideas?
>
> Thanks,
> Tom
>

This problem was reported recently on IRC too. A simple workaround for
the problem is to replace

  if (sys_interface_version >= SYS_IFACE_MIN_VERS_NUMA) {

with

  if (sys_interface_version >= SYS_IFACE_MIN_VERS_NUMA && conn != NULL) {

In the code snippet you posted.

Matthias