[libvirt] [PATCH v4 RESEND 1/4] threadpool impl
Hu Tao
hutao at cn.fujitsu.com
Fri Dec 3 02:49:25 UTC 2010
On Thu, Dec 02, 2010 at 12:28:17PM +0000, Daniel P. Berrange wrote:
<...snip...>
> > +
> > + if (virThreadCreate(&pool->workers[pool->nWorkers - 1],
> > + true,
> > + virThreadPoolWorker,
> > + pool) < 0) {
> > + pool->nWorkers--;
> > + goto error;
> > + }
>
> Small typo, that check should "!= NULL", rather than "< 0".
Confused. Do you mean virThreadCreate() or VIR_ALLOC() below? But both
return int.
>
> > + }
> > +
> > + if (VIR_ALLOC(job) < 0) {
> > + virReportOOMError();
> > + goto error;
> > + }
--
Thanks,
Hu Tao
More information about the libvir-list
mailing list