[libvirt] [PATCH] virsh: Remove redundant optional option for cmdHelp

Justin Clift jclift at redhat.com
Fri Dec 3 17:12:18 UTC 2010


On 04/12/2010, at 2:24 AM, Eric Blake wrote:
> On 12/03/2010 12:34 AM, Osier Yang wrote:
>> Remove the optional option "group", as cmdHelp should accepts
>> only one option, and rename option "command" as "command-or-group",
>> ("virsh help" supports both command and command group now, and user
>> nealy uses the options, so it doesn't matter much for it being longer,
>> :-)
>> 
>> * tools/virsh.c
>> ---
>> tools/virsh.c |    8 ++------
>> 1 files changed, 2 insertions(+), 6 deletions(-)
> 
> Given the ensuing discussion, I'm pushing with this squashed in.

Thanks Eric, that works well.  I'll push a matching tweak to the man page in a
minute too (under the trivial rule).





More information about the libvir-list mailing list