[libvirt] [PATCH v6 3/4] Add a watchdog action `dump'
Hu Tao
hutao at cn.fujitsu.com
Fri Dec 10 00:28:31 UTC 2010
On Thu, Dec 09, 2010 at 12:00:48PM -0700, Eric Blake wrote:
> On 12/07/2010 11:19 PM, Hu Tao wrote:
> > `dump' watchdog action lets libvirtd to dump the guest when receives a
> > watchdog event (which probably means a guest crash)
> >
> > Currently only qemu is supported.
> > ---
> > src/conf/domain_conf.c | 1 +
> > src/conf/domain_conf.h | 1 +
> > src/qemu/libvirtd_qemu.aug | 1 +
> > src/qemu/qemu.conf | 5 ++
> > src/qemu/qemu_conf.c | 16 ++++++-
> > src/qemu/qemu_conf.h | 5 ++
> > src/qemu/qemu_driver.c | 96 +++++++++++++++++++++++++++++++++++++++
> > src/qemu/test_libvirtd_qemu.aug | 2 +
> > 8 files changed, 126 insertions(+), 1 deletions(-)
>
> Needed a bit of conflict resolution given other patches that have gone
> in since this was posted, as well as a tweak to pass 'make check'
> (test_libvirtd_qemu.aug was incomplete), but I've now pushed this patch
> since it had an ACK. As Daniel said, I'm omitting patch 4, and looking
> forward to his larger rewrite (which I did promise to review:
> https://www.redhat.com/archives/libvir-list/2010-December/msg00073.html).
>
> However, as Justin pointed out, the new dump option still needs
> documentation and testing:
> - mention 'dump' in docs/formatdomain.html.in
> - update to docs/schemas/domain.rng to list dump as a valid option
> - add an .xml file somewhere under tests/ that exercises the new XML option
OK, will update it.
--
Thanks,
Hu Tao
More information about the libvir-list
mailing list