[libvirt] [PATCHv2 2/3] util: introduce virWaitPid

Eric Blake eblake at redhat.com
Sat Dec 11 21:00:59 UTC 2010


On 12/10/2010 05:07 PM, Eric Blake wrote:
> * src/util/util.h (virWaitPid): New prototype.
> * src/util/util.c (virWaitPid): Implement it.
> * src/util/command.c (virCommandWait): Use it.
> * src/libvirt_private.syms: Export it.
> ---
> 
> Should I convert over most remaining instances of waitpid() and
> add a 'make syntax-check' entry?  The only place that can't
> convert is lxc_controller.c (it uses WNOHANG instead of 0), but
> lxc is already Linux-specific, so it can be exempted from a
> syntax-check.

self-NACK.  Gnulib provides a waitpid() module, that we should just use
instead of redoing it ourselves.
-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20101211/e6f66111/attachment-0001.sig>


More information about the libvir-list mailing list