[libvirt] [C# bindings] [PATCH]

[arnaud.champion at devatom.fr]



--------------------------------------------------
From: "Matthias Bolte" <matthias.bolte at googlemail.com>
Sent: Thursday, December 16, 2010 1:44 PM
To: <arnaud.champion at devatom.fr>
Cc: <libvir-list at redhat.com>
Subject: Re: [libvirt] [C# bindings] [PATCH]

> 2010/12/8  <arnaud.champion at devatom.fr>:
>> Hi there,
>>
>> a long time since some update for C# bindings, sorry, I'm a little busy.
>> Anyway here are some patches that correct marshaling around network
>> functions, and as usual a new sample code related to network functions.
>>
>
> 0001-Network-function-marhsalling-corrections.patch:
> ACK and pushed it.
>
> There are GetUUIDString functions for other types too, do they need
> the same treatment?
>

Yep, that's right.

>
> 0001-New-sample-virNetwork-for-network-related-samples.patch:
> Is there a specific reason for naming the new example virNetworkd for
> VisualStudio? I think this is a typo. Is that correct, then I will
> rename it to virNetworks before pushing it?
>

Oops my mistake :S sorry. this should be "virNetwork"

> The new example leaks _conn and _network. I'd like to see leak free
> examples. Just yesterday I fixed a memory leak in the VirtualBox
> driver that we inherited from the leaky example code in the VirtualBox
> SDK.
>

:S I haven't understand (my poor english) what mean "leaks" ?

>
> 0001-Some-naming-correction-in-samples.patch:
> ACK and pushed it.
>
> Matthias
>