[libvirt] [PATCH] vmware: Fix undefine symbol with loadable drivers enabled
Matthias Bolte
matthias.bolte at googlemail.com
Tue Dec 21 22:13:35 UTC 2010
2010/12/21 Eric Blake <eblake at redhat.com>:
> On 12/21/2010 02:51 PM, Matthias Bolte wrote:
>> All other drivers are explicitly linked to gnulib. The VMware
>> driver lacked this, resulting in mdir_name being an undefine
>> symbol.
>
> That's the minimum impact on glibc. The impact on other systems like
> mingw would be even bigger, due to lots of missing rpl_ functions.
>
>>
>> Explicitly link the VMware driver to gnulib to fix this.
>> ---
>> src/Makefile.am | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/src/Makefile.am b/src/Makefile.am
>> index 607e391..7ecd3e0 100644
>> --- a/src/Makefile.am
>> +++ b/src/Makefile.am
>> @@ -633,6 +633,7 @@ endif
>> libvirt_driver_vmware_la_CFLAGS = \
>> -I at top_srcdir@/src/conf -I at top_srcdir@/src/vmx
>> if WITH_DRIVER_MODULES
>> +libvirt_driver_vmware_la_LIBADD = ../gnulib/lib/libgnu.la
>
> ACK.
>
Thanks, pushed.
Matthias
More information about the libvir-list
mailing list