[libvirt] [PATCHv2 03/13] Fix logging of failed iptables commands

Eric Blake eblake at redhat.com
Wed Dec 22 23:13:12 UTC 2010


On 12/22/2010 11:58 AM, Laine Stump wrote:
> The functions in iptables.c all return -1 on failure, but all their
> callers (which all happen to be in bridge_driver.c) assume that they
> are returning an errno, and the logging is done accordingly. This
> patch fixes all the error checking and logging to assume < 0 is an
> error, and nothing else.

ACK from v1 stands.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20101222/9b69a349/attachment-0001.sig>


More information about the libvir-list mailing list