[libvirt] [PATCH] update docs for network disks

Eric Blake eblake at redhat.com
Fri Dec 24 15:21:22 UTC 2010


On 12/24/2010 04:41 AM, MORITA Kazutaka wrote:
> Signed-off-by: MORITA Kazutaka <morita.kazutaka at lab.ntt.co.jp>
> ---
>  docs/formatdomain.html.in |   49 ++++++++++++++++++++++++++++++++++++++++++--
>  1 files changed, 46 insertions(+), 3 deletions(-)

Thanks for picking this up.

> 
> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> index cfd3451..86c2d0d 100644
> --- a/docs/formatdomain.html.in
> +++ b/docs/formatdomain.html.in
> @@ -628,23 +628,39 @@
>          ...
>        </serial>
>      </disk>
> +      ...
> +    <disk type='network'>
> +      <driver name="qemu" type="raw"/>
> +      <source protocol="sheepdog" name="image_name">
> +        <host name="hostname" port="7000">

missing / before >

> +        disks. The <code>type</code> attribute is either "file", "block", "dir", or "network"

Long line; I broke it (and several others) to fit in 80 columns.

> +        <span class="since">Since 0.0.3; "device" attribute since 0.1.4;
> +        "network" attribute value since after 0.8.6 (QEMU and KVM only)</span></dd>

I simplified the wording slightly:

Since 0.0.3; "device" attribute since 0.1.4; "network" attribute since 0.8.7

ACK; I pushed after fixing those nits.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20101224/a05f5686/attachment-0001.sig>


More information about the libvir-list mailing list