[libvirt] [PATCH] qemu: improve efficiency of dd during snapshots
Eric Blake
eblake at redhat.com
Thu Dec 30 15:47:12 UTC 2010
On 12/30/2010 01:48 AM, Paweł Krześniak wrote:
> On Wed, Dec 22, 2010 at 22:06, Eric Blake <eblake at redhat.com> wrote:
>> diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
>> index 7877731..284f9c4 100644
>> --- a/src/qemu/qemu_monitor_json.c
>> +++ b/src/qemu/qemu_monitor_json.c
>> @@ -1695,10 +1695,11 @@ int qemuMonitorJSONMigrateToFile(qemuMonitorPtr mon,
>> * <> redirection to avoid truncating a regular file. */
>> if (virAsprintf(&dest, "exec:" VIR_WRAPPER_SHELL_PREFIX "%s | "
>> "{ dd bs=%llu seek=%llu if=/dev/null && "
>> - "dd bs=%llu; } 1<>%s" VIR_WRAPPER_SHELL_SUFFIX,
>> + "dd ibs=%llu; obs=%llu } 1<>%s" VIR_WRAPPER_SHELL_SUFFIX,
>
> typo: semicolon before obs. Should be:
> "dd ibs=%llu obs=%llu } 1<>%s" VIR_WRAPPER_SHELL_SUFFIX,
Thanks for the review. But your correction is also wrong. It should be:
"dd ibs=%llu obs=%llu; } 1<>%s"
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20101230/d796a98c/attachment-0001.sig>
More information about the libvir-list
mailing list