[libvirt] [PATCH 0/9] virDomain{Attach, Detach}DeviceFlags patches

[Daniel P. Berrange]

On Mon, Feb 08, 2010 at 05:16:25PM -0500, Chris Lalancette wrote:
> On 02/08/2010 01:51 PM, Jim Fehlig wrote:
> > I have pushed this series now that 0.7.6 is released.  The only change
> > from reviewed and ACK'ed patches is adjustment of
> > src/libvirt_public.syms to assumed next release of 0.7.7.
> > 
> > Thanks for input during specification of these APIs and review of the
> > patches!
> 
> Jim,
>      Current libvirt won't build for me after this series.  I get:
> 
>   CC     libvirt_driver_remote_la-remote_driver.lo
> remote/remote_driver.c: In function 'remoteDomainAttachDeviceFlags':
> remote/remote_driver.c:3064: error: 'remote_domain_attach_device_flags_args' undeclared (first use in this function)
> remote/remote_driver.c:3064: error: (Each undeclared identifier is reported only once
> remote/remote_driver.c:3064: error: for each function it appears in.)
> remote/remote_driver.c:3064: error: expected ';' before 'args'
> remote/remote_driver.c:3069: error: 'args' undeclared (first use in this function)
> remote/remote_driver.c:3073: error: 'REMOTE_PROC_DOMAIN_ATTACH_DEVICE_FLAGS' undeclared (first use in this function)
> remote/remote_driver.c:3074: error: 'xdr_remote_domain_attach_device_flags_args' undeclared (first use in this function)
> remote/remote_driver.c: In function 'remoteDomainDetachDeviceFlags':
> remote/remote_driver.c:3114: error: 'remote_domain_detach_device_flags_args' undeclared (first use in this function)
> remote/remote_driver.c:3114: error: expected ';' before 'args'
> remote/remote_driver.c:3119: error: 'args' undeclared (first use in this function)
> remote/remote_driver.c:3123: error: 'REMOTE_PROC_DOMAIN_DETACH_DEVICE_FLAGS' undeclared (first use in this function)
> remote/remote_driver.c:3124: error: 'xdr_remote_domain_detach_device_flags_args' undeclared (first use in this function)
> 
> I suspect you have to run "cd src ; make rpcgen", and then check the resulting
> src/remote/remote_protocol.c and src/remote/remote_protocol.h into the
> repository to get things to work again.

Yep, don't worry about this - I've re-generated & pushed the files


Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|