[libvirt] [PATCH 1/9] Functions for computing baseline CPU from a set of host CPUs
Daniel P. Berrange
berrange at redhat.com
Wed Feb 10 18:08:29 UTC 2010
On Fri, Feb 05, 2010 at 04:56:50PM +0100, Jiri Denemark wrote:
> Baseline CPU is the best CPU which can be used for a guest on any of the
> hosts.
>
> Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> ---
> src/cpu/cpu.c | 125 +++++++++++++++++++++++++++++++++++++++++++++-
> src/cpu/cpu.h | 23 ++++++++-
> src/cpu/cpu_generic.c | 3 +-
> src/cpu/cpu_x86.c | 3 +-
> src/libvirt_private.syms | 2 +
> 5 files changed, 152 insertions(+), 4 deletions(-)
>
> diff --git a/src/cpu/cpu.c b/src/cpu/cpu.c
> index 3e46948..1438d13 100644
> --- a/src/cpu/cpu.c
> +++ b/src/cpu/cpu.c
> @@ -1,7 +1,7 @@
> /*
> * cpu.c: internal functions for CPU manipulation
> *
> - * Copyright (C) 2009 Red Hat, Inc.
> + * Copyright (C) 2009--2010 Red Hat, Inc.
> *
> * This library is free software; you can redistribute it and/or
> * modify it under the terms of the GNU Lesser General Public
> @@ -23,6 +23,7 @@
>
> #include <config.h>
>
> +#include "memory.h"
> #include "xml.h"
> #include "cpu.h"
> #include "cpu_x86.h"
> @@ -245,3 +246,125 @@ cpuGuestData(virConnectPtr conn,
>
> return driver->guestData(host, guest, data);
> }
> +
> +
> +char *
> +cpuBaselineXML(virConnectPtr conn,
> + unsigned int ncpus,
> + const char **xmlCPUs,
> + unsigned int nmodels,
> + const char **models)
In the other APIs we have, the array length is typically after
the array pointer. Could you swap this array here to match and
the other related places
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
More information about the libvir-list
mailing list