[libvirt] [PATCH 4/4] remote: Detect 'nc' version incompatibilities

Daniel P. Berrange berrange at redhat.com
Mon Feb 15 11:11:21 UTC 2010


On Fri, Feb 12, 2010 at 10:32:17AM -0500, Cole Robinson wrote:
> This ugly thing is a shell script to detect availability of
> the -q option for 'nc': debian and suse based distros need this
> flag to ensure the remote nc will exit on EOF, so it will go away
> when we close the tunnel. If it doesn't go away, a useless 'nc'
> process is left sitting on the remote host.
> 
> Fedora's 'nc' doesn't have this option, so we can't blindly pass -q.
> More info here:

I don't really like this approach. Shouldn't it be sufficient to
just explicit SIGKILL the ssh client, rather than relying on the
exit-on-EOF behaviour of nc.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|




More information about the libvir-list mailing list