[libvirt] [PATCH] build: fix typos in configure-set makefile variable names

[Diego Elio “Flameeyes” Pettenò]

Il giorno mer, 24/02/2010 alle 15.05 +0100, Jim Meyering ha scritto:
> 
> That sounds reasonable, if we're guaranteed always to have a libdl.
> However, the fact that it's not needed on F12 suggests that we should
> be adding it only when necessary (hence a configure-time test). 

I guess the problem might lie in the way the VirtualBox driver's
dependencies are linked; didn't FC13/Rawhide move to use --no-add-needed
by default?

If that's the case you have two options:

 - a bug in the VirtualBox driver's dependencies, that causes some of
the libraries not to link to libdl;
 - the VirtualBox driver *does* need libdl, but never linked it in by
itself as it relied on the --add-needed behaviour.

Easy way to test this is to try configuring on Rawhide with
LDFLAGS="-Wl,--add-needed" and see what happens… if it builds fine, it's
the latter.

On the other hand, you do have one problem: libdl is only present in
glibc/uclibc, as other C libraries have it part of the base library, so
I'd suggest adding a configure test.

If Richard can confirm whether it's the case, I should be able to write
one fairly quickly, I hope, as I have something similar laying around.

-- 
Diego Elio Pettenò — “Flameeyes”
http://blog.flameeyes.eu/

If you found a .asc file in this mail and know not what it is,
it's a GnuPG digital signature: http://www.gnupg.org/