[libvirt] [PATCH] Take Two - Fix domain restore for files on root-squash NFS.

[Laine Stump]

Thanks once again for the informative review! (I've learned something 
new about git, which isn't really surprising I supposed, since I 
currently know so little ;-))

On 02/25/2010 12:34 PM, Eric Blake wrote:
> According to Laine Stump on 2/24/2010 1:58 PM:
>    
>> (This version incorporates the suggestions from Jim Meyering and Eric Blake)
>>      
> I guess that line is okay to leave in the commit message.  If it had been
> me, though, I would have left it out of the commit log, and just inserted
> it between the --- and diffstat during 'git send-email --annotate' - it is
> relevant to the thread that explains the updated commit and how it differs
> from the first attempt, but it is not really related to the patch itself.
>   After all, at the end of the day, the original version of this patch will
> not be in libvirt.git, so the words "This version" no longer have any
> context for comparison.

I agree with that, just didn't know that git send-email could do that! 
;-) I contemplated doing --compose and putting all that stuff in the 
separate introductory email, but that seemed a bit too verbose and 
complicating. Instead, I decided to rely on DV (or whoever pushed the 
change) to remove those bits from the message before running git am.

>   Likewise, a subject line of "[PATCHv2] Fix..." is
> better than "[PATCH] Take Two - Fix...", since git am strips
> "[PATCH...]" but not "Take Two".
>    

Can git send-email be made to put that in the subject line rather than 
just [PATCH] or [PATCH n/m]? That would be really useful!