[libvirt] [PATCH] Only build virDomainObjFormat if not building proxy.
Chris Lalancette
clalance at redhat.com
Fri Feb 26 13:46:27 UTC 2010
On 02/25/2010 06:09 PM, Eric Blake wrote:
> According to Chris Lalancette on 2/25/2010 12:48 PM:
>> While building under RHEL-5, I got a compile warning because
>> virDomainObjFormat was defined but not used. That came about
>> because in RHEL-5 we build with "#define PROXY", and
>> virDomainObjFormat is only used with !PROXY. Move the
>> define.
>
> ACK.
Thanks, pushed now.
>
>>
>> Signed-off-by: Chris Lalancette <clalance at redhat.com>
>
> Is there a project policy on Signed-off-by lines? According to the git
> documentation, it only means something if everyone agrees on what it means
> (on one extreme, the kernel uses it to track that contributions are not
> license-encumbered, as well as treating it as an audit trail of who has
> touched the commit; on the other extreme, coreutils avoids it altogether,
> on the assumption that no one has commit rights without first assigning
> copyright). Right now, 'git log' makes it look like libvirt's S-o-b usage
> is ad hoc, according to the contributor's habits.
Yeah, as DV said, it's pretty much ad-hoc. I do it out of habit with other
projects, and nobody seems to mind :).
--
Chris Lalancette
More information about the libvir-list
mailing list