[libvirt] fix build failure with --disable-shared

Diego Elio “Flameeyes” Pettenò flameeyes at gmail.com
Thu Jan 7 22:21:04 UTC 2010

Il giorno gio, 07/01/2010 alle 23.03 +0100, Jim Meyering ha scritto:
> So your change forced all other users of --disable-shared
> to also configure with --without-python, but did not inform them
> of the new constraint.  BTW, it also rendered build instructions
> in the FAQ invalid. 

I don't want to sound defensive, but I *do* feel attacked a bit here,
and I don't think I made any mistake in my patch and suggestion.

If I did “force” users to configure properly, it was because the build
system was working on a wrong assumption before. Sorry if I made it
known that there is a bug there.

As for the build instructions, I had to look them up now because I
definitely hadn't looked at them; if I did, I would have et you know
earlier about the fact that it's a *bad* advice to give.

Why? Because I guess quite a few people interested in using libvirt
would also be using virt-manager (especially since Daniel said that the
XML files are not designed for user to edit, but for software to mangle)
and that only works with proper Python bindings — and they are not
generated with the suggested syntax in the FAQ.

It actually can create quite a bad thing if the user tries to be smart
and install the CVS (CVS? I thought it was developed in GIT) versions
with make install after the configure, as the bindings and the
virsh/libvirtd executables will be using very different libraries.

Do I ask too much if next time, rather than noticing by chance that
somebody wants to revert a change I proposed, you would reply to my own
posting (which I watch more closely), letting me know it broke
something? I'm pretty sure I can fix up things from there myself.

Diego Elio Pettenò — “Flameeyes”

If you found a .asc file in this mail and know not what it is,
it's a GnuPG digital signature: http://www.gnupg.org/

More information about the libvir-list mailing list