[libvirt] [PATCH] gnulib added a new syntax-check test: use $(VAR), not @VAR@

Daniel P. Berrange berrange at redhat.com
Fri Jan 15 17:57:26 UTC 2010

On Fri, Jan 15, 2010 at 11:11:08AM +0100, Jim Meyering wrote:
> Updating to newer gnulib also pulled in a new sytnax-check
> test that evoked new warnings.  No big deal, but I addressed them.
> The only trick was to see that the warnings about @SCHEMADIR@
> and @SYSCONFDIR@ were false positives.  To allow them, I defined
> the variable in cfg.mk.  See below.
> >From 6e76cfe38ba0ccafa7c4e81dcc0af04e31f8f447 Mon Sep 17 00:00:00 2001
> From: Jim Meyering <meyering at redhat.com>
> Date: Fri, 15 Jan 2010 11:09:01 +0100
> Subject: [PATCH] gnulib added a new syntax-check test: use $(VAR), not @VAR@
> The latter is not officially "wrong", but *is* terribly anachronistic.

ACK, it is way overdue for us to standarize on $(VAR) rather than
arbitrarily mixing the two syntax

|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

More information about the libvir-list mailing list