[libvirt] [PATCH] usbFindBusByVendor: don't leak a DIR buffer and FD

Laine Stump laine at laine.org
Tue Jan 26 18:19:18 UTC 2010

On 01/26/2010 10:04 AM, Daniel P. Berrange wrote:
> Yep, generally speaking if a caller needs to be given back the actual
> errno value, then the function should be returing  '-errno' instead
> of the fixed -1.

-errno? Interesting. I recently fixed calls to virFileMakePath which 
were looking for return < 0 to look for return != 0, because it returns 
the value of errno (not -errno) in case of an error. Should I have 
changed virFileMakePath to return -errno instead? All of the negations 
through different paths in multiple layers might start to get confusing...

More information about the libvir-list mailing list