[libvirt] [PATCH] avoid newly-introduced test failure

Jim Meyering jim at meyering.net
Sat Jan 9 08:29:18 UTC 2010


I ran "make check" and was surprised to see a failure:

    10) QEMU XML-2-ARGV hugepages                                 ... FAILED
    ...
    FAIL: qemuxml2argvtest

Introduced just a couple days ago.
Here's the fix:

>From a4e9edbd77f428782293b9672098b6d3c80b2879 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering at redhat.com>
Date: Sat, 9 Jan 2010 09:25:04 +0100
Subject: [PATCH] avoid newly-introduced test failure

* tests/qemuxml2argvdata/qemuxml2argv-hugepages.args: Update
expected output to match, now that we use -mem-prealloc.
---
 tests/qemuxml2argvdata/qemuxml2argv-hugepages.args |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tests/qemuxml2argvdata/qemuxml2argv-hugepages.args b/tests/qemuxml2argvdata/qemuxml2argv-hugepages.args
index f10a40e..1e2632a 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-hugepages.args
+++ b/tests/qemuxml2argvdata/qemuxml2argv-hugepages.args
@@ -1 +1 @@
-LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test /usr/bin/qemu -S -M pc -m 214 -mem-path /dev/hugepages/libvirt/qemu -smp 1 -nographic -monitor unix:/tmp/test-monitor,server,nowait -no-acpi -boot c -hda /dev/HostVG/QEMUGuest1 -net none -serial none -parallel none -usb
+LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test /usr/bin/qemu -S -M pc -m 214 -mem-prealloc -mem-path /dev/hugepages/libvirt/qemu -smp 1 -nographic -monitor unix:/tmp/test-monitor,server,nowait -no-acpi -boot c -hda /dev/HostVG/QEMUGuest1 -net none -serial none -parallel none -usb
--
1.6.6.439.gaf68f

In case you can't read the above, note that all the change
does is to insert "-mem-prealloc " before "-mem-path"

I'm about to push this, now.




More information about the libvir-list mailing list