[libvirt] [PATCH] daemon: Fix compilation error of dispatch.c

[Ryota Ozaki]

On Thu, Jul 8, 2010 at 3:31 AM, Ryota Ozaki <ozaki.ryota at gmail.com> wrote:
> On Thu, Jul 8, 2010 at 2:40 AM, Daniel Veillard <veillard at redhat.com> wrote:
>> On Thu, Jul 08, 2010 at 01:55:23AM +0900, Ryota Ozaki wrote:
>>> > Unfortunately the errors still happen after updating. Even worse, they happen
>>> > on an old commit that I was able to compile successfully so far. So I guess
>>> > my box went wrong at some point.
>>>
>>> FYI. My box has repaired by removing /usr/local/include/rpc/ which is
>>> installed by
>>> portablexdr to build MinGW cross-compile environment. I don´t know why/how the
>>> headers affect to libvirt compilation.
>>
>>  Huh, that's weird, maybe the compiler takes /usr/local/include/blah...
>> before /usr/include/blah...
>
> My box's gcc seems trying to search /usr/local/include firstly...
> I'm not sure this is expected behavior or not.

Anyway, dispatch.c requires stdio.h but now it implicitly depends on that
rpc/xdr.h includes stdio.h.

[Inclusions]
dispatch.c
  libvirtd.h
    rpc/xdr.h
      stdio.h

I think including stdio.h explicitly in dispatch.c is not bad idea.
How do you think, Daniel?

  ozaki-r


>
> gcc -v dispatch.c 2>&1 |grep include
> ignoring nonexistent directory
> "/usr/lib/gcc/x86_64-redhat-linux/4.4.4/include-fixed"
> ignoring nonexistent directory
> "/usr/lib/gcc/x86_64-redhat-linux/4.4.4/../../../../x86_64-redhat-linux/include"
> #include "..." search starts here:
> #include <...> search starts here:
>  /usr/local/include
>  /usr/lib/gcc/x86_64-redhat-linux/4.4.4/include
>  /usr/include
> In file included from dispatch.h:28,
> In file included from dispatch.h:28,
> In file included from dispatch.c:26:
> In file included from remote.h:31,
> In file included from remote.h:35,
> In file included from dispatch.c:27:
>
> $ gcc -v
> Using built-in specs.
> Target: x86_64-redhat-linux
> Configured with: ../configure --prefix=/usr --mandir=/usr/share/man
> --infodir=/usr/share/info
> --with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-bootstrap
> --enable-shared --enable-threads=posix --enable-checking=release
> --with-system-zlib --enable-__cxa_atexit
> --disable-libunwind-exceptions --enable-gnu-unique-object
> --enable-languages=c,c++,objc,obj-c++,java,fortran,ada
> --enable-java-awt=gtk --disable-dssi --enable-plugin
> --with-java-home=/usr/lib/jvm/java-1.5.0-gcj-1.5.0.0/jre
> --enable-libgcj-multifile --enable-java-maintainer-mode
> --with-ecj-jar=/usr/share/java/eclipse-ecj.jar
> --disable-libjava-multilib --with-ppl --with-cloog --with-tune=generic
> --with-arch_32=i686 --build=x86_64-redhat-linux
> Thread model: posix
> gcc version 4.4.4 20100630 (Red Hat 4.4.4-10) (GCC)
>
> $ which gcc
> /usr/bin/gcc
>
> $ rpm -qf /usr/bin/gcc
> gcc-4.4.4-10.fc12.x86_64
>
>
> Thanks.
>  ozaki-r
>
>
>>
>> Daniel
>>
>> --
>> Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
>> daniel at veillard.com  | Rpmfind RPM search engine http://rpmfind.net/
>> http://veillard.com/ | virtualization library  http://libvirt.org/
>>
>