[libvirt] [PATCH 0/2] build: fix bugs detected by newer gcc

Eric Blake eblake at redhat.com
Wed Jul 28 23:34:13 UTC 2010

Rawhide's gcc 4.5.0 got smarter in relation to Fedora 13's gcc 4.4.4,
and exposed a real bug (introduced by commit ed9c14a7 this January)
as well as extra noise that is easy enough to silence.

The new warnings looked like:

esx/esx_vi_types.c:1231:1: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]

And the esx_vi_types.c case is proof why it is a bad idea to ever
stick -Werror in a spec file - upgrade the compiler, and something
that previously built silently can now fail to build; in contrast,
using -Werror during development is great as it forces you to think
about the issue, and in the case of xen, fix a real bug.

Eric Blake (2):
  xen: fix logic bug
  esx: silence spurious compiler warning

 src/esx/esx_vi_types.c  |    6 ++++--
 src/xen/xend_internal.c |    6 +++---
 2 files changed, 7 insertions(+), 5 deletions(-)


More information about the libvir-list mailing list