[libvirt] [PATCH] Eliminate memory leak in xenUnifiedDomainInfoListFree
Chris Lalancette
clalance at redhat.com
Thu Jul 29 14:13:19 UTC 2010
On 07/29/10 - 09:47:53AM, Laine Stump wrote:
> From: Laine Stump <laine at redhat.com>
>
> This fixes a leak described in
>
> https://bugzilla.redhat.com/show_bug.cgi?id=590073
>
> xenUnifiedDomainInfoList has a pointer to a list of pointers to
> xenUnifiedDomain. We were freeing up all the domains, but neglecting
> to free the list.
>
> This was found by Paolo Bonzini <pbonzini at redhat.com>.
> ---
> src/xen/xen_driver.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/src/xen/xen_driver.c b/src/xen/xen_driver.c
> index d121ea4..ddbfa7a 100644
> --- a/src/xen/xen_driver.c
> +++ b/src/xen/xen_driver.c
> @@ -2044,6 +2044,7 @@ xenUnifiedDomainInfoListFree(xenUnifiedDomainInfoListPtr list)
> VIR_FREE(list->doms[i]->name);
> VIR_FREE(list->doms[i]);
> }
> + VIR_FREE(list->doms);
> VIR_FREE(list);
> }
Ouch.
ACK
--
Chris Lalancette
More information about the libvir-list
mailing list