[libvirt] [PATCH v4 2/8] Qemu arbitrary command-line arguments.

[Eric Blake]

On 07/07/2010 03:33 PM, Chris Lalancette wrote:
> Implement the qemu hooks for XML namespace data.  This
> allows us to specify a qemu XML namespace, and then
> specify:
>
> <qemu:commandline>
>   <qemu:arg value='arg'/>
>   <qemu:env name='name' value='value'/>
> </qemu:commandline>
>
> In the domain XML.
>
> Changes since v1:
>   - Change the<qemu:arg>arg</qemu:arg>  XML to<qemu:arg value='arg'/>  XML
>   - Fix up some memory leaks in qemuDomainDefNamespaceParse
>   - Rename num_extra and extra to num_args and args, respectively
>   - Fixed up some error messages
>   - Make sure to escape user-provided data in qemuDomainDefNamespaceFormatXML
>
> Changes since v2:
>   - Add checking to ensure environment variable names are valid
>   - Invert the logic in qemuDomainDefNamespaceFormatXML to return early
>
> Changes since v3:
>   - Change strspn() to c_isalpha() check of first letter of environment variable

ACK that change addressed all my comments from earlier versions.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org