[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v4 6/8] Qemu remote protocol.

On 07/07/2010 03:33 PM, Chris Lalancette wrote:
Since we are adding a new "per-hypervisor" protocol, we
make it so that the qemu remote protocol uses a new
PROTOCOL and PROGRAM number.  This allows us to easily
distinguish it from the normal REMOTE protocol.

This necessitates changing the proc in remote_message_header
from a "remote_procedure" to an "unsigned", which should
be the same size (and thus preserve the on-wire protocol).

Changes since v1:
  - Fixed up a couple of script problems in remote_generate_stubs.pl
  - Switch an int flag to a bool in dispatch.c

Changes since v2:
  - None

Changes since v3:
  - Change unsigned proc to signed proc, to conform to spec

Sorry for not noticing sooner, but this breaks 'make check' if you have dwarves installed:

  GEN    remote_protocol-structs
--- remote_protocol-structs-t	2010-07-23 16:27:22.361836563 -0600
+++ ./remote_protocol-structs	2010-07-23 09:45:22.190053074 -0600
@@ -1308,7 +1308,7 @@
 struct remote_message_header {
 	u_int                      prog;
 	u_int                      vers;
-	int                        proc;
+	remote_procedure           proc;
 	remote_message_type        type;

I'll be checking the trivial fix under the obvious rule.

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]