[libvirt] [PATCH] Fix a memory leak in the qemudBuildCommandLine.

Eric Blake eblake at redhat.com
Fri Jul 30 14:02:08 UTC 2010


On 07/30/2010 07:47 AM, Chris Lalancette wrote:
> ADD_ARG_LIT should only be used for literal arguments,
> since it duplicates the memory.  Since virBufferContentAndReset
> is already allocating memory, we should only use ADD_ARG.

ACK.

Hmm, wondering if there is a way to make use of gcc's
__builtin_constant_p() to enforce that ADD_ARG_LIT is passed a string
constant.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100730/911ce6cb/attachment-0001.sig>


More information about the libvir-list mailing list