[libvirt] [PATCH] storage: kill dead stores
Eric Blake
eblake at redhat.com
Fri Jul 30 20:22:05 UTC 2010
On 07/30/2010 12:20 PM, Matthias Bolte wrote:
>> @@ -75,7 +73,7 @@ virStorageBackendProbeTarget(virStorageVolTargetPtr target,
>> allocation,
>> capacity)) < 0) {
>> close(fd);
>> - return -1;
>> + return ret;
>
> Why do you return ret here? Doing so doesn't harm but it's not
> necessary, virStorageBackendUpdateVolTargetInfoFD returns 0 or -1
> only, in contrast to virStorageBackendVolOpenCheckMode that can return
> 0, -1 or -2.
The alternative was to delete the dead assignment to ret, since we would
be returning -1 ourselves.
>
> ACK.
Thanks; pushed.
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100730/b311f827/attachment-0001.sig>
More information about the libvir-list
mailing list