[libvirt] [PATCH 1/2] Fix dereference of potentially freed pointer in qemudDomainSaveFlags

[Eric Blake]

On 06/03/2010 09:57 PM, Laine Stump wrote:
> The pointer to the xml describing the domain is saved into an object
> prior to calling VIR_REALLOC_N() to make the size of the memory it
> points to a multiple of QEMU_MONITOR_MIGRATE_TO_FILE_BS. If that
> operation needs to allocate new memory, the pointer that was saved is
> no longer valid.
> 
> To avoid this situation, adjust the size *before* saving the pointer.

ACK.  Subtle bugs like that can be a bear to track down.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100604/3040468f/attachment-0001.sig>