[libvirt] [PATCH 1/1] Fix leaks in udev device add/remove v3

Eric Blake eblake at redhat.com
Tue Jun 8 18:38:47 UTC 2010


On 06/07/2010 11:23 AM, David Allan wrote:
> * This patch is a modification of a patch submitted by Nigel Jones.
>   It fixes several memory leaks on device addition/removal:
> 
> 1. Free the virNodeDeviceDefPtr in udevAddOneDevice if the return
>    value is non-zero
> 
> 2. Always release the node device reference after the device has been
>    processed.
> 
> * Refactored for better readability per the suggestion of clalance

Yes, in comparing the two versions, I can see the improvement.  ACK on
this version.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100608/87bab74c/attachment-0001.sig>


More information about the libvir-list mailing list