[libvirt] [PATCH 3/3] virsh: add --paused option to create

Eric Blake eblake at redhat.com
Tue Jun 8 19:53:52 UTC 2010


* tools/virsh.c (opts_create): Add --paused option.
(cmdCreate): Pass appropriate flag.
* tools/virsh.pod: Document it.
---

I'm following my own review advice of documenting changes
in virsh.pod as I make them :)

 tools/virsh.c   |    6 +++++-
 tools/virsh.pod |    6 ++++--
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/tools/virsh.c b/tools/virsh.c
index 1279f41..6b05949 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -1141,6 +1141,7 @@ static const vshCmdOptDef opts_create[] = {
 #ifndef WIN32
     {"console", VSH_OT_BOOL, 0, N_("attach to console after creation")},
 #endif
+    {"paused", VSH_OT_BOOL, 0, N_("leave the guest paused after creation")},
     {NULL, 0, 0, NULL}
 };

@@ -1155,6 +1156,9 @@ cmdCreate(vshControl *ctl, const vshCmd *cmd)
 #ifndef WIN32
     int console = vshCommandOptBool(cmd, "console");
 #endif
+    unsigned int paused = (vshCommandOptBool(cmd, "paused")
+                           ? VIR_DOMAIN_START_PAUSED
+                           : VIR_DOMAIN_NONE);

     if (!vshConnectionUsability(ctl, ctl->conn, TRUE))
         return FALSE;
@@ -1166,7 +1170,7 @@ cmdCreate(vshControl *ctl, const vshCmd *cmd)
     if (virFileReadAll(from, VIRSH_MAX_XML_FILE, &buffer) < 0)
         return FALSE;

-    dom = virDomainCreateXML(ctl->conn, buffer, 0);
+    dom = virDomainCreateXML(ctl->conn, buffer, paused);
     VIR_FREE(buffer);

     if (dom != NULL) {
diff --git a/tools/virsh.pod b/tools/virsh.pod
index 08e361d..3cadb87 100644
--- a/tools/virsh.pod
+++ b/tools/virsh.pod
@@ -265,11 +265,13 @@ The option I<--disable> disables autostarting.

 Connect the virtual serial console for the guest.

-=item B<create> I<FILE>
+=item B<create> I<FILE> optional I<--console> I<--paused>

 Create a domain from an XML <file>. An easy way to create the XML
 <file> is to use the B<dumpxml> command to obtain the definition of a
-pre-existing guest.
+pre-existing guest.  The domain will be paused if the I<--option>
+is used and supported by the driver; otherwise it will be running.
+If I<--console> is requested, attach to the console after creation.

 B<Example>

-- 
1.7.0.1




More information about the libvir-list mailing list