[libvirt] [PATCH 1/4] Index hashes by UUID instead of name

Matthias Bolte matthias.bolte at googlemail.com
Fri Jun 18 17:08:22 UTC 2010


2010/6/17 Jiri Denemark <jdenemar at redhat.com>:
> Per-connection hashes for domains, networks, storage pools and network
> filter pools were indexed by names which was not the best choice. UUIDs
> are better identifiers, so lets use them.

Well, the comments say the same: "UUID is better than the name has
key", but why? Because they are more random than the name and might
result in less collisions in the hash?

Also ID, name and UUID must be unique per domain anyway.

> ---
>  src/datatypes.c |   64 +++++++++++++++++++++++++++++++------------------------
>  1 files changed, 36 insertions(+), 28 deletions(-)
>

Anyway, ACK.

Matthias




More information about the libvir-list mailing list