[libvirt] [PATCH] phyp: Adding storage management driver

Justin Clift justin at salasaga.org
Sat Jun 19 08:17:32 UTC 2010


On 06/19/2010 09:33 AM, Eric Blake wrote:
<snip>
>> +    if (!(profile = phypGetLparProfile(conn, domain->id))) {
>> +        VIR_ERROR("%s", "Unable to get VIOS profile name.");
>> +        goto err;
>> +    }
>
> Another case of a missing string translation.  How come 'make
> syntax-check' isn't catching it?

It also didn't catch some untranslated "yes" and "no" strings in virsh.c 
that were recently fixed (after being manually noticed).

Guess that needs to be looked at if it's not just virsh that it's not 
working correctly on. :/

Regards and best wishes,

Justin Clift

-- 
Salasaga  -  Open Source eLearning IDE
               http://www.salasaga.org




More information about the libvir-list mailing list