[libvirt] [PATCH] Don't leak open fd to virsh in libvirt-guests init script
Eric Blake
eblake at redhat.com
Tue Jun 22 15:24:42 UTC 2010
On 06/22/2010 08:56 AM, Jiri Denemark wrote:
> Running virsh while having /var/lib/libvirt/libvirt-guests file open
> makes SELinux emit messages about preventing virsh from reading that
> file. Since virsh doesn't really want to read anything, it's better to
> run it with /dev/null on stdin to prevent those messages.
> ---
> daemon/libvirt-guests.init.in | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/daemon/libvirt-guests.init.in b/daemon/libvirt-guests.init.in
> index 17e6824..f99c070 100644
> --- a/daemon/libvirt-guests.init.in
> +++ b/daemon/libvirt-guests.init.in
> @@ -61,7 +61,7 @@ run_virsh() {
> conn="-c $uri"
> fi
>
> - virsh $conn "$@"
> + virsh $conn "$@" </dev/null
ACK.
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100622/18791a7e/attachment-0001.sig>
More information about the libvir-list
mailing list