[libvirt] [PATCH] Check for presence of qemu -nodefconfig option before using it
Laine Stump
laine at laine.org
Thu Jun 24 20:20:30 UTC 2010
>
> On 06/24/2010 12:52 PM, Laine Stump wrote:
>
>> We previously assumed that if the -device option existed in qemu, that
>> -nodefconfig would also exist. It turns out that isn't the case, as
>> demonstrated by qemu-kvm-0.12.3 in Fedora 13.
>>
>> */src/qemu/qemu_conf.[hc] - add a new QEMUD_CMD_FLAG, set it via the
>> help output, and check it before adding
>> -nodefconfig to the qemu commandline.
>> ---
>> src/qemu/qemu_conf.c | 5 ++++-
>> src/qemu/qemu_conf.h | 1 +
>> 2 files changed, 5 insertions(+), 1 deletions(-)
>>
> Does this impact any of the existing test cases for qemu -h parsing?
>
No.
> And if not, should we add a new file to tests/qemuhelpdata/ that exposes
> a known qemu version that does support -nodefconfig?
>
I don't think there is currently a publicly available qemu release that
supports -nodefconfig. Should we wait until one exists, or dummy up a
test file?
More information about the libvir-list
mailing list