[libvirt] [PATCH 1/2] Adding Storage Management driver (semantic changes)
Eric Blake
eblake at redhat.com
Thu Jun 24 22:06:29 UTC 2010
On 06/23/2010 04:49 PM, Eduardo Otubo wrote:
> + virBufferVSprintf(&buf, "|sed -e 's/^LV IDENTIFIER://' -e 's/\\ //g'");
You still missed some of these instances of non-portable '\ ' escape to
sed. I've cleaned it up in my refactoring.
> + virBufferVSprintf(&buf, "\'");
Minor optimization - it is rather more efficient to use
virBufferAddChar(&buf, '\'') than virBufferVSprintf(&buf, "\'") - I've
added that in my refactoring.
> + if (system_type == HMC) {
> + virBufferVSprintf(&buf, "viosvrcmd -m %s --id %d -c ",
> + managed_system, vios_id);
> + virBufferVSprintf(&buf, "'lsvg -lv %s -field lvname'", pool->name);
> + } else {
> + virBufferVSprintf(&buf, "lsvg -lv %s -field lvname", pool->name);
> + }
> + virBufferVSprintf(&buf, "grep -c '^.*$'");
And this was still a disaster waiting to happen for non-HVMC (passing
-field lvnamegrep to lsvg instead of piping lsvg -field name to grep).
Are you sure you caught all of my review issues from the first time around?
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100624/72d8d258/attachment-0001.sig>
More information about the libvir-list
mailing list