[libvirt] [PATCHv3 3/4] phyp: add storage management driver

[Justin Clift]

On 06/25/2010 08:32 AM, Eric Blake wrote:
> From: Eduardo Otubo<otubo at linux.vnet.ibm.com>
>
> Add the storage management driver to the Power Hypervisor driver.
> This is a big but simple patch, it's just a new set of functions.
>
> This patch includes:
>   * Storage driver: The set of pool-* and vol-* functions.
>   * attach-disk function.
>   * Support for IVM on the new functions.
>
> Signed-off-by: Eric Blake<eblake at redhat.com>
<snip>

This commit is causing a segfault here when running "pool-list" in 
unmodified virsh.

virConnectNumOfStoragePools() calls phypNumOfStoragePools(), which calls 
phypExec(). In this case with session equaling NULL.

That's flowing through to libssh2_channel_open_ex(), which tries to 
access data in the (NULL) session structure and segfaults.

Screenshots here, illustrating the problem session variable at each 
point in the backtrace:

   http://justinclift.fedorapeople.org/screenshots/screenshot0001.png
   http://justinclift.fedorapeople.org/screenshots/screenshot0002.png
   http://justinclift.fedorapeople.org/screenshots/screenshot0003.png
   http://justinclift.fedorapeople.org/screenshots/screenshot0004.png

Note the "Target request failed: Cannot access memory at address 
0x4700." in the bottom right of the screenshot0001.png file.  That's 
when it attempts to access the session->open_state value, causing the 
segfault.

Rolling back 2 commits to this entry, makes the above segfault go away:

    8914453 phyp: reduce scope of driver functions

Hope that helps.

Regards and best wishes,

Justin Clift

-- 
Salasaga  -  Open Source eLearning IDE
                http://www.salasaga.org