[libvirt] [PATCH] Avoid invoking the qemu monitor destroy callback if the constructor fails
Eric Blake
eblake at redhat.com
Tue Jun 29 13:15:56 UTC 2010
On 06/29/2010 05:02 AM, Daniel P. Berrange wrote:
> Some, but not all, codepaths in the qemuMonitorOpen() method
> would trigger the destroy callback. The caller does not expect
> this to be invoked if construction fails, only during normal
> release of the monitor. This resulted in a possible double-unref
> of the virDomainObjPtr, because the caller explicitly unrefs
> the virDomainObjPtr if qemuMonitorOpen() fails
>
> * src/qemu/qemu_monitor.c: Don't invoke destroy callback from
> qemuMonitorOpen() failure paths
ACK.
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100629/41e3e77e/attachment-0001.sig>
More information about the libvir-list
mailing list