[libvirt] [PATCH] qemu: Improve some qemu.conf error reporting
Eric Blake
eblake at redhat.com
Wed Jun 30 21:05:56 UTC 2010
On 06/30/2010 02:38 PM, Cole Robinson wrote:
> Log some info if we can't find a config file. Make parse failures
> fatal, and actually raise an error message.
>
> Signed-off-by: Cole Robinson <crobinso at redhat.com>
ACK.
> #define CHECK_TYPE(name,typ) if (p && p->type != (typ)) { \
> qemuReportError(VIR_ERR_INTERNAL_ERROR, \
> - "remoteReadConfigFile: %s: %s: expected type " #typ, \
> - filename, (name)); \
> + "%s: %s: %s: expected type " #typ, \
> + __func__, filename, (name)); \
Hmm, this reminds me of my pending question of whether we should prefer
__func__ (C99, and guaranteed by gnulib) or __FUNCTION__ (gcc-only, but
easy to wrap on top of __func__):
https://www.redhat.com/archives/libvir-list/2010-May/msg00319.html
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100630/bfbf7996/attachment-0001.sig>
More information about the libvir-list
mailing list