[libvirt] [PATCH] Change default for storage uid/gid from getuid()/getgid() to -1/-1

[Laine Stump]

On 03/02/2010 05:48 AM, Daniel P. Berrange wrote:
> On Tue, Mar 02, 2010 at 02:17:59AM -0500, Laine Stump wrote:
>    
>> +    uid_t uid = (vol->target.perms.uid == -1) ? getuid() : vol->target.perms.uid;
>> +    gid_t gid = (vol->target.perms.gid == -1) ? getgid() : vol->target.perms.gid;
>>      
> This sounds good, but can we encapsulate this conditional logic in a helper
> function or macro. eg
>
>     uid_t uid = virVolumeDefGetUID(vol)
>
> and so on for later areas of the patch
>    

Sure. That will be putting the getuid/getgid calls back into 
storage_conf (.h at least), but it will make things a bit more readable.

I'll make a new version.