[libvirt] [PATCH option 1] Use fallocate directly if possible

Eric Blake eblake at redhat.com
Tue Mar 2 17:08:50 UTC 2010

According to Daniel Veillard on 3/2/2010 9:53 AM:
>>> +#if defined(HAVE_POSIX_FALLOCATE) && !defined(HAVE_FALLOCATE)
>> Redundant parenthesis.  I know upstream gnulib's maint.mk warns about
>> them; did we turn them off in libvirt's 'make syntax-check'?
>   Hum,  what's redundant here ?

It's perfectly acceptable (and less typing) to do:


Whether it is also more legible is a matter of opinion.

Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 320 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100302/4f347ae6/attachment-0001.sig>

More information about the libvir-list mailing list