[libvirt] [PATCH 0/2] virsh: consistent N_() usage

Eric Blake eblake at redhat.com
Wed Mar 3 19:14:27 UTC 2010

As discussed here[1], we aren't being very smart about the use
of gettext_noop().  In particular, most packages use N_() to
mean gettext_noop rather than a synonym to _(); furthermore,
our current definition of N_() meant that we were effectively
calling gettext(gettext("string")), which has undefined results.

Patch 1/2 also fixes a potential crash due to a translation bug,
by telling xgettext to enforce that the translation of a string
later handed to printf does not violate printf constraints.

[1] https://www.redhat.com/archives/libvir-list/2010-March/msg00197.html

 [PATCH 1/2] virsh: fix existing N_ uses
 [PATCH 2/2] virsh: use N_ rather than gettext_noop

 .../0008-Step-8-of-8-Add-virsh-support.patch       |   21 +-
 src/internal.h                                     |    2 +-
 tools/virsh.c                                      |  895 ++++++++++----------
 3 files changed, 459 insertions(+), 459 deletions(-)

More information about the libvir-list mailing list