[libvirt] [PATCH 2/2] build: enforce preprocessor indentation
Jim Meyering
jim at meyering.net
Tue Mar 9 18:13:52 UTC 2010
Eric Blake wrote:
> On 03/09/2010 10:02 AM, Eric Blake wrote:
>> * cfg.mk (sc_preprocessor_indentation): New syntax-check rule.
>
> I don't see 1/2 in the archives yet; perhaps it was held up by
> moderation, because it is big? (400k)
That was it. I approved it.
> At any rate, I've pushed it to my cloned repo, if that makes life any
> easier:
> http://repo.or.cz/w/libvirt/ericb.git/commitdiff/4d3b7e06bc8e
>
> Patch 1/2 is entirely mechanical; the most helpful review would be on
> whether any of the affected files are normally generated, where either
> we add exceptions, or fix the generator, so as to avoid regressions when
> those files are regenerated.
There's at least one. See below.
> commit 4d3b7e06bc8e2e76584da369406df0909c63f2d4
> Author: Eric Blake <eblake at redhat.com>
> Date: Tue Mar 9 09:33:48 2010 -0700
>
> build: consistently indent preprocessor directives
>
> * global: patch created by running:
> for f in $(git ls-files '*.[ch]') ; do
> cppi $f > $f.t && mv $f.t $f
> done
>
...
> src/remote/remote_driver.h | 30 +-
> src/remote/remote_protocol.h | 88 ++--
The above is generated from the .x file.
It's probably best just to exempt it for now.
More information about the libvir-list
mailing list