[libvirt] [PATCH 2/14] Add build support

Eric Blake eblake at redhat.com
Thu Mar 18 19:11:09 UTC 2010

On 03/18/2010 09:16 AM, Stefan Berger wrote:
> This patch adds build support for the network filtering framework.
> Signed-off-by: Stefan Berger <stefanb at us.ibm.com>

Some nits, but I'll let others more familiar with the process of API
expansion give an actual ack/nak review.

> +NWFILTER_CONF_SOURCES =                                         \
> +		conf/nwfilter_conf.c conf/nwfilter_conf.h

What's with the mix between tabs and spaces before the \?

Moreover, it seems a bit odd to hook up the Makefile support in 2/14
when the new files don't exist until 12/14.  But I guess that's okay as
long as the automake conditional that enables this block of code doesn't
trigger until the files exist.

> fi
> +if test "$with_nwfilter" = "yes" ; then
> +  AC_DEFINE_UNQUOTED([WITH_NWFILTER], 1, [whether local network filter management driver is available])
> +fi

You can use AC_DEFINE instead of AC_DEFINE_UNQUOTED here, since you
aren't doing any shell expansion on either WITH_NWFILTER or 1.

Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 323 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100318/08f91dd3/attachment-0001.sig>

More information about the libvir-list mailing list