[libvirt] Sleeping 50 microseconds in qemuDomainWaitForMigrationComplete?

Matthias Bolte matthias.bolte at googlemail.com
Wed Mar 24 23:31:09 UTC 2010


There is this nanosleep call in the QEMU driver.

/* Poll every 50ms for progress & to allow cancellation */
struct timespec ts = { .tv_sec = 0, .tv_nsec = 50 * 1000ull };
[...]
nanosleep(&ts, NULL);

The comment says 50ms (assuming m is for milli and not for micro.
because normally u is used for micro) but the actual nanosleep call is
done with 50 microseconds.

Is the comment right and the code wrong? I assume so, because 50
microseconds is pretty short and 50 milliseconds sounds more
reasonable.

Matthias




More information about the libvir-list mailing list