[libvirt] [PATCH] tests: teach syntax-check that virDomainDefFree has free-like semantics

Eric Blake eblake at redhat.com
Thu Mar 25 21:19:51 UTC 2010

On 03/25/2010 02:56 PM, Jim Meyering wrote:
> Thanks for highlighting that.
> Our syntax-check rule should have caught it.
> With the following change, it does, along with one other:
>     src/conf/domain_conf.c: if (domain->newDef)
>                     virDomainDefFree(domain->newDef)
>     src/test/test_driver.c: if (def)
>             virDomainDefFree(def)
>     maint.mk: found useless "if" before "free" above
>     make: *** [sc_avoid_if_before_free] Error 1
> This also fixes the one not fixed by Jiri's change.


Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 323 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100325/c5c34b47/attachment-0001.sig>

More information about the libvir-list mailing list