[libvirt] [PATCH 2/2] virsh: support VISUAL, and allow metacharacters in EDITOR

Eric Blake eblake at redhat.com
Mon Mar 29 22:47:39 UTC 2010

On 03/13/2010 07:35 AM, Matthias Bolte wrote:
> 2010/3/12 Eric Blake <eblake at redhat.com>:
>> Common Unix practice is to prefer VISUAL over EDITOR, particularly if
>> the editor of choice spawns a new window.  Thus, it is also common to
>> see settings like EDITOR='emacs -nw', with the expectation that the
>> shell will parse this as an argument to 'emacs' and not try to invoke
>> a file containing a space.
>> +=item EDITOR
>> +
>> +The editor to use by the B<edit> and B<net-edit> options, if C<VISUAL>
>> +is not set.
>> +
> There is also a pool-edit and iface-edit command.

It turns out these are not documented at all in virsh.pod (that is, it
is a separate patch to bring all of virsh.pod up-to-date to match
current implementation, which I hope to submit soon).

> ACK.

Pushed as-is, in light of bug 487738 that promised this by the next
release (the doc cleanups shouldn't hold up the ACK'd functionality fix).

Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 323 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100329/23bd0a15/attachment-0001.sig>

More information about the libvir-list mailing list