[libvirt] [PATCH 1/3] xenXMDomainConfigParse: avoid dead store
Eric Blake
eblake at redhat.com
Fri Mar 5 17:52:50 UTC 2010
According to Jim Meyering on 3/5/2010 10:27 AM:
> Here are three dead-store removals:
>
> Subject: [PATCH 1/3] xenXMDomainConfigParse: avoid dead store
>
> * src/xen/xm_internal.c (xenXMDomainConfigParse): Avoid dead store
> to local, "data". Remove declaration, too.
> @@ -1367,7 +1367,6 @@ xenXMDomainConfigParse(virConnectPtr conn, virConfPtr conf) {
> graphics->type = VIR_DOMAIN_GRAPHICS_TYPE_VNC;
>
> while (key) {
> - char *data;
> char *nextkey = strchr(key, ',');
> char *end = nextkey;
> if (nextkey) {
> @@ -1375,7 +1374,7 @@ xenXMDomainConfigParse(virConnectPtr conn, virConfPtr conf) {
> nextkey++;
> }
>
> - if (!(data = strchr(key, '=')))
> + if (!strchr(key, '='))
ACK to all 3
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 320 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100305/0c771134/attachment-0001.sig>
More information about the libvir-list
mailing list