[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix copy&paste typos in virProcessInfoGetAffinity

On Tue, Mar 09, 2010 at 08:35:09AM -0700, Eric Blake wrote:
> On 03/09/2010 06:59 AM, Jiri Denemark wrote:
> > +++ b/src/util/processinfo.c
> > @@ -130,31 +130,31 @@ realloc:
>                         ^^^^^^^^
> Is there a policy on indentation of labels?  By default, emacs starts

  start on first column is what you will see all over the code.

> labels in column 2, so that utilities that expect only function names to
> appear in column 1 behave in a more predictable manner.  I'm not sure

  I don't use emacs myself and don't expect everybody to use it either.

> what indent(1) does in this case.  At any rate, the git hunk header
> detection regexp is an example of an external tool that expects to find
> only function names on column 1, and which is being thrown off by the

then it should be fixed in some ways, or we should not rely on it, if
it's just an indication factor in patches, it's a slight annoyance but
not worth a change though all the code.

We have used labels starting in the first column nearly everywhere,
no reason to change it everywhere because of an editor preference
at this point.


Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]