[libvirt] [PATCH] dont't crash in virsh dominfo <domain>

Guido Günther agx at sigxcpu.org
Wed Mar 17 20:11:07 UTC 2010


Hi,

virsh dominfo domain crashes with:

#0  strlen () at ../sysdeps/i386/i486/strlen.S:69
#1  0x080891c9 in qemudNodeGetSecurityModel (conn=0x8133940, secmodel=0xb5676ede) at qemu/qemu_driver.c:4911
#2  0xb7eb5623 in virNodeGetSecurityModel (conn=0x8133940, secmodel=0x0) at libvirt.c:5118
#3  0x0806767a in remoteDispatchNodeGetSecurityModel (server=0x8118888, client=0x8134080, conn=0x8133940, hdr=0x81a8388, rerr=0xb56771d8, args=0xb56771a0, ret=0xb5677144) at remote.c:1306
#4  0x08068acc in remoteDispatchClientCall (server=0x8118888, client=0x8134080, msg=0x8168378) at dispatch.c:506
#5  0x08068ee3 in remoteDispatchClientRequest (server=0x8118888, client=0x8134080, msg=0x8168378) at dispatch.c:388
#6  0x0805baba in qemudWorker (data=0x811de2c) at libvirtd.c:1528
#7  0xb7bb8585 in start_thread (arg=0xb5677b70) at pthread_create.c:300
#8  0xb7b3a29e in clone () at ../sysdeps/unix/sysv/linux/i386/clone.S:130

if there's no primary security driver set since we only intialize the
secmodel.model and secmodel.doi if we have one. Attached patch checks
for primarySecurityDriver instead of securityDriver since the later is
always set in qemudSecurityInit().
Cheers,
 -- Guido
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Don-t-crash-without-a-security-driver.patch
Type: text/x-diff
Size: 1073 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100317/a3d6725a/attachment-0001.bin>


More information about the libvir-list mailing list